[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: Use virReportSystemError for system error in pci.c



On 11/23/2012 09:02 AM, Osier Yang wrote:
> ---
>  src/util/pci.c |   14 ++++++--------
>  1 files changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/src/util/pci.c b/src/util/pci.c
> index d1ad121..191f99d 100644
> --- a/src/util/pci.c
> +++ b/src/util/pci.c
> @@ -1860,10 +1860,9 @@ pciGetPciConfigAddressFromSysfsDeviceLink(const char *device_link,
>      device_path = canonicalize_file_name(device_link);
>      if (device_path == NULL) {
>          memset(errbuf, '\0', sizeof(errbuf));
> -        virReportError(VIR_ERR_INTERNAL_ERROR,
> -                       _("Failed to resolve device link '%s': '%s'"),
> -                       device_link, virStrerror(errno, errbuf,
> -                       sizeof(errbuf)));
> +        virReportSystemError(errno,
> +                             _("Failed to resolve device link '%s'"),
> +                             device_link);
>          return ret;
>      }
>  
> @@ -1941,10 +1940,9 @@ pciGetVirtualFunctions(const char *sysfs_path,
>      dir = opendir(sysfs_path);
>      if (dir == NULL) {
>          memset(errbuf, '\0', sizeof(errbuf));
> -        virReportError(VIR_ERR_INTERNAL_ERROR,
> -                       _("Failed to open dir '%s': '%s'"),
> -                       sysfs_path, virStrerror(errno, errbuf,
> -                       sizeof(errbuf)));
> +        virReportSystemError(errno,
> +                             _("Failed to open dir '%s'"),
> +                             sysfs_path);
>          return ret;
>      }
>  
> 

These are system errors indeed. ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]