[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Correct include-password option for domdisplay



On 11/23/2012 09:20 AM, Christophe Fergeau wrote:
> On Thu, Nov 22, 2012 at 11:32:38AM +0100, Ján Tomko wrote:
>> On 11/22/12 11:03, Martin Kletzander wrote:
>>>
>>> I'll rework it to make it "as URI as possible" then.  Just one question,
>>> though (for anyone, I guess); why do we append port as a parameter for
>>> spice scheme?
>>>
>>> Martin
>>>
>>
>> I think it's because of what spicy supported initially (since v0.1.0):
>> http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=f0693b9f949ba
>>
>> spice://<host>:<port> is supported since v0.8
>> http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=b4c72ece9ca3b
>>
>> and spice://<host>:<port>/ (with the trailing slash) since v0.12
>> http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=50add15ef69cd
> 
> Another thing to keep in mind is that you can have both a port and a secure
> port (over which data will transit through SSL).
> 
> Christophe
> 

I'm keeping that in the parameter as there will be both port and tlsPort
available in this case.  I also modified it so we have a vnc version and
spice version of the output, which can be seen in v2 (rewrite
cmdDomDisplay).

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]