[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 2/2][RFC] help to create disk images of non-shared migration



On 23.11.2012 06:28, liguang wrote:
> try to do non-shared migration without bothering to
> create disk images at target by hand.
> 
> consider this situation:
> 1. non-shared migration
>    virsh migrate --copy-storage-all ...
> 2. migration fails
> 3. create disk images required
>    qemu-img create ...
> 4  migration run smoothly
> so, try do remove step 2, 3, 4
> 
> this kind of usage had been discussed before,
> http://www.redhat.com/archives/libvir-list/2011-December/msg00451.html
> 
> this patch depends on my support offline migration patch:
> https://www.redhat.com/archives/libvir-list/2012-November/msg00512.html
> 
> Signed-off-by: liguang <lig fnst cn fujitsu com>
> ---
>  src/qemu/qemu_conf.h      |    2 +
>  src/qemu/qemu_driver.c    |    1 +
>  src/qemu/qemu_migration.c |  275 ++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 277 insertions(+), 1 deletions(-)

Actually, I am working on NBD based storage migration. That is
nbd-server-* command family (run on dst) + drive-mirror (run on src).
There is similar prerequisite - the files on dst MUST have at least the
same size as on src. So I will implement main idea of this patch anyway.
However, when I'm done I think this one will be longer no needed.
The thing is - I need a slightly more general migration cookie - to
negotiate if NBD feature is used and on which port.

IOW - I am not saying no one shall look at your patch, but maybe we
should wait a while until I post my patches and see if they cover yours.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]