[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 4/4] tests: Add tests for gluster protocol based network disks support



On Thu, Nov 22, 2012 at 23:40:41 +0530, Harsh Prateek Bora wrote:
> Signed-off-by: Harsh Prateek Bora <harsh linux vnet ibm com>
> ---
>  tests/qemuargv2xmltest.c                           |  1 +
>  .../qemuxml2argv-disk-drive-network-gluster.args   |  1 +
>  .../qemuxml2argv-disk-drive-network-gluster.xml    | 34 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  4 files changed, 38 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.xml
> 
> diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c
> index 5e51d32..bcea8fe 100644
> --- a/tests/qemuargv2xmltest.c
> +++ b/tests/qemuargv2xmltest.c
> @@ -183,6 +183,7 @@ mymain(void)
>      DO_TEST("disk-drive-cache-directsync");
>      DO_TEST("disk-drive-cache-unsafe");
>      DO_TEST("disk-drive-network-nbd");
> +    DO_TEST("disk-drive-network-gluster");
>      DO_TEST("disk-drive-network-rbd");
>      /* older format using CEPH_ARGS env var */
>      DO_TEST("disk-drive-network-rbd-ceph-env");
> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.args
> new file mode 100644
> index 0000000..c07c8d0
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.args
> @@ -0,0 +1 @@
> +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -drive file=gluster+tcp://example.org:6000/Volume1/Image,if=virtio,format=raw -drive 'file=gluster+unix:///Volume2/Image?socket=/path/to/sock,if=virtio,format=raw' -net none -serial none -parallel none -usb

One of the recent patches moved -usb earlier in the command line (just after
"-boot c" in this case)...

ACK with the small tweak.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]