[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [java PATCH] Fix build with jna >= 3.5.0



On Tue, Nov 27, 2012 at 13:10:57 -0500, Eric Blake wrote:
> > +    protected java.util.List getFieldOrder() {
> > +        return java.util.Arrays.asList(new String[] {
> > +            "credtype", "ncredtype", "cb", "cbdata" });
> > +    }
> 
> Isn't it sufficient to write:
> 
>   return java.util.Arrays.asList("credtype", "ncredtype", "cb", "cbdata")
> 
> and let Java do the conversion from var-args to String[] with less typing
> on your part?

Hmm, I guess so. I didn't actually think about this part too much, I just
copied the style used in jna itself :-)

> But that's cosmetic.  ACK whether you go as-is or use shorter syntax.

Thanks, I pushed this patch as-is.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]