[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] virsh: check the return value of virStoragePoolGetAutostart



On 11/30/12 13:09, Ján Tomko wrote:
On error, virStoragePoolGetAutostart would return -1 leaving autostart
untouched.

Removed the misleading debug message as well.

Error: CHECKED_RETURN (CWE-252):
libvirt-0.10.2/tools/virsh-pool.c:1386: unchecked_value: No check of the
     return value of "virStoragePoolGetAutostart(pool, &autostart)".
---
  tools/virsh-pool.c |    5 +----
  1 files changed, 1 insertions(+), 4 deletions(-)


ACK.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]