[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 01/11] bandwidth: add new 'floor' attribute



On 11/19/2012 11:51 AM, Michal Privoznik wrote:
> This is however supported only on domain interfaces with
> type='network'. Moreover, target network needs to have at least
> inbound QoS set. This is required by hierarchical traffic shaping.
>
> >From now on, the required attribute for <inbound/> is either 'average'
> (old) or 'floor' (new). This new attribute can be used just for
> interfaces type of network (<interface type='network'/>) currently.

Another thing that I just thought of - this patch needs to update
virNetdevBandwidthEqual to check floor, otherwise qemuNetChange won't
properly detect when bandwidth is changed (btw, a small patch to do the
right thing when that happens (similar to the patch I recently sent to
support changing filters) would be really nice :-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]