[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: fix scsi detach regression with cgroup ACLs



> > https://bugzilla.redhat.com/show_bug.cgi?id=876828
> > 
> > Commit 38c4a9cc introduced a regression in hot unplugging of disks
> > from qemu, where cgroup device ACLs were no longer being revoked
> > (thankfully not a security hole: cgroup ACLs only prevent open()
> > of the disk; so reverting the ACL prevents future abuse but doesn't
> > stop abuse from an fd that was already opened before the ACL
> > change).
> > 
> > Commit 1b2ebf95 overlooked that there were two spots affected.
> > 

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]