[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: don't attempt undefined QMP commands



> > https://bugzilla.redhat.com/show_bug.cgi?id=872292
> > 
> > Libvirt should not attempt to call a QMP command that has not been
> > documented in qemu.git - if future qemu introduces a command by the
> > same name but with subtly different semantics, then libvirt will be
> > broken when trying to use that command.
> 
> The reason these were added was that back in the first days of QMP
> the intention was that every HMP command would have an identical
> QMP command. This plan changed before it was ever completed, hence
> the situation we're in now.

Yep :)


> > +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > +                       _("JSON monitor should be using
> > netdev_del"));
> 
> In these two you recommend different commands
> 

> > +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > +                       _("JSON monitor should be using
> > AddDrive"));
> 
> while this one recommends a different method
> 
> 
> ACK you standardize on one.

I standardized on the method name, improved the commit message
to give more details about the commands being deleted from QMP
support (since they were dead code based on qemu_hotplug.c
usage patterns), and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]