[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.



On 10/04/2012 07:32 PM, Jiri Denemark wrote:
On Thu, Oct 04, 2012 at 19:01:58 +0530, Harsh Prateek Bora wrote:
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows users to specify disks on gluster backends like this:

     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
       <source protocol='gluster' name='volume/image'>
         <host name='example.org' port='6000' transport='tcp'/>
       </source>
       <target dev='vda' bus='virtio'/>
     </disk>

Note: In the <host> element above, transport is an optional attribute.
Valid transport values are tcp, unix or rdma. If none specified, tcp is assumed.
If transport type is unix, host name specifies path to unix socket.

Signed-off-by: Harsh Prateek Bora <harsh linux vnet ibm com>
---
  docs/schemas/domaincommon.rng |   8 ++
  src/conf/domain_conf.c        |  28 +++++-
  src/conf/domain_conf.h        |  11 +++
  src/libvirt_private.syms      |   2 +
  src/qemu/qemu_command.c       | 204 ++++++++++++++++++++++++++++++++++++++++++
  5 files changed, 251 insertions(+), 2 deletions(-)

Oh, I just realized that this patch is missing documentation in
docs/formatdomain.html.in. Sorry for not noticing that in v1. Anyway, no need
to resend the whole series just for this. It's sufficient if you send an
additional patch to add just the documentation and it can be squashed while
pushing or in v3, depending what the result of v2 review is going to be.

Hm, I should have included that in v1 as well, will send a patch or include in v3 if there are other changes required.


I'll do a proper review later.


Thanks,
Harsh

Jirka



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]