[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Added QEMU support for IVSHMEM devices

On Thu, Oct 04, 2012 at 09:53:49AM -0600, Eric Blake wrote:
> On 09/24/2012 09:44 AM, Shawn Furrow wrote:
> [sorry for my delay in replying]
> > *Created at Virginia Tech's Systems Software Research Group
> > 
> > This patch adds the XML schema and implementation for IVSHMEM device driver     
> > support. Currently it defaults to using interrupts. A sample IVSHMEM entry     
> > in the VM's XML file is:
> Thanks for starting to tackle this.
> > 
> > <ivshmem id='nahanni' size='16834' path='/tmp/'/>
> Elsewhere, we have represented memory sized in KiB (1024 byte units);
> what scale are you using here?  A default unit of byte might be nicer,
> on the other hand, does shared memory have to be page aligned, at which
> point it will always be a multiple of 4k (and thus listing in KiB still
> makes sense)?  At any rate, I think that this argues you need to support
> units on output to show the preferred scale, as well as parse it on
> input to allow users to specify units='M' size='1' to reserve 2**20
> bytes with ease.

I think it'd be worthwhile to push some of the attributes
down to a subelement, eg

  <ivshmem id='nahanni'>
      <source size="12345" units="M" path='/tmp'/>

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]