[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] private.syms: Drop virKillProcess



On 10/05/2012 05:36 AM, Michal Privoznik wrote:
> After it got renamed to virProcessKill (cf470068a11)
> it is no longer needed in the private syms file.
> ---
> 
> It is trivial, but maybe worth inventing cfg.mk macro
> that does check if all symbols fro private syms are
> defined somewhere. However, I am not that familiar
> with cfg.mk, so if anybody has any idea ...

src/check-symfile.pl ought to be able to flag this case as part of 'make
check'; I'm not sure why it is failing to do what it claims.

> +++ b/src/libvirt_private.syms
> @@ -1246,7 +1246,6 @@ virGetUserName;
>  virHexToBin;
>  virIndexToDiskName;
>  virIsDevMapperDevice;
> -virKillProcess;

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]