[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] S390: Buffer too small for large CPU numbers.



On 10/05/2012 07:59 AM, Viktor Mihajlovski wrote:
> The output buffer for virFileReadAll was too small for systems with
> more than 30 CPUs which leads to a log entry and incorrect behavior.
> The new size will be sufficient for the current
> architectural limits.

It doesn't hurt to go larger, say to 64k, if that will help prevent the
need to bump this again in the future.  But I'm trusting you that your
choice of 8k is sufficient, as I don't have an s390 machine to test on, so:

ACK and pushed.

>      /* Gather info from /proc/cpuinfo */
> -    if (virFileReadAll(CPUINFO, 2048, &outbuf) < 0) {
> +    if (virFileReadAll(CPUINFO, 8192, &outbuf) < 0) {
>          virReportError(VIR_ERR_INTERNAL_ERROR,
>                         _("Failed to open %s"), CPUINFO);

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]