[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] conf: Generalize life cycle actions to event actions



On Thu, Sep 27, 2012 at 04:41:31PM +0200, Jiri Denemark wrote:
> While current on_{poweroff,reboot,crash} action configuration is about
> configuring life cycle actions, they can all be considered events and
> actions that need to be done on a particular event. Let's generalize the
> code this way so that it can be reused later for non-lifecycle events.
> ---
>  docs/formatdomain.html.in     | 15 ++++++----
>  docs/schemas/domaincommon.rng |  8 +++---
>  src/conf/domain_conf.c        | 66 +++++++++++++++++++++++--------------------
>  src/conf/domain_conf.h        |  4 +--
>  4 files changed, 51 insertions(+), 42 deletions(-)

ACK

By 'generalize' it looks like you just meant 'rename', since I don't see
any real functional change there

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]