[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [re-send][PATCH 1/3] add qemu driver hook



On 10/08/2012 07:51 PM, liguang wrote:
> this hook aimed at migration only, it supposed
> to be used as a helper of migrate --copy-storage-*
> features to remove the unreasonable limitation
> of pre-exist disk images at migration target.
> someone can add more functions to hook files.

NACK.  Instead of writing a hook that runs outside of libvirt and has to
be installed to be of use, we should instead fix libvirt to do the file
creation itself.  That is, you should be patching
src/qemu/qemu_migration.c to detect when copy-storage-* has been passed,
and to then pre-create the proper empty files and give them correct
SELinux labels.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]