[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nodeinfo: Fully convert to new virReportError



On Tue, Oct 09, 2012 at 03:19:44PM +0200, Michal Privoznik wrote:
> With our latest s/[a-z]+ReportError/virReportError/ rewrite
> (47ab34e2) we forgot to update arm part of the code.
> ---
> 
> Thanks to my masochist idea of compiling libvirt
> on my Raspberry PI I've discovered this.
> 
> Pushing under trivial & build breaker (on arm platforms obviously) rules.
> 
> For those who are interested, it took ages and we
> don't build cleanly:
> 
>    http://pastebin.com/dkrJaV5Z
> 
> But I am not sure how to fix those 'cast increases required
> alignment of target type' warnings. And I am not sure anybody
> else is ever going to use libvirt on arm.

It's available through yum with the Raspberry Pi Fedora remix [and
works for the small amount of testing I did with it and virt-manager
controlling remote systems], so I don't think it's all that
farfetched.

Dave

>  src/nodeinfo.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/nodeinfo.c b/src/nodeinfo.c
> index 4cbfe63..c0e60d8 100644
> --- a/src/nodeinfo.c
> +++ b/src/nodeinfo.c
> @@ -423,8 +423,8 @@ int linuxNodeInfoCPUPopulate(FILE *cpuinfo,
>                  buf++;
>  
>              if (*buf != ':' || !buf[1]) {
> -                nodeReportError(VIR_ERR_INTERNAL_ERROR,
> -                                "%s", _("parsing cpu MHz from cpuinfo"));
> +                virReportError(VIR_ERR_INTERNAL_ERROR,
> +                               "%s", _("parsing cpu MHz from cpuinfo"));
>                  goto cleanup;
>              }
>  
> -- 
> 1.7.8.6
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]