[libvirt] [PATCH 5/7] snapshot: qemu: Rename qemuDomainSnapshotCreateActive

Peter Krempa pkrempa at redhat.com
Tue Oct 9 13:39:35 UTC 2012


By now, libvirt supported only internal snapshots for active guests.
This patch renames this function to qemuDomainSnapshotCreateActiveInternal
to prepare the grounds for external active snapshots.
---
 src/qemu/qemu_driver.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index b8ea289..297ae29 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -10447,13 +10447,14 @@ qemuDomainSnapshotCreateInactive(struct qemud_driver *driver,
     return qemuDomainSnapshotForEachQcow2(driver, vm, snap, "-c", false);
 }

+
 /* The domain is expected to be locked and active. */
 static int
-qemuDomainSnapshotCreateActive(virConnectPtr conn,
-                               struct qemud_driver *driver,
-                               virDomainObjPtr *vmptr,
-                               virDomainSnapshotObjPtr snap,
-                               unsigned int flags)
+qemuDomainSnapshotCreateActiveInternal(virConnectPtr conn,
+                                       struct qemud_driver *driver,
+                                       virDomainObjPtr *vmptr,
+                                       virDomainSnapshotObjPtr snap,
+                                       unsigned int flags)
 {
     virDomainObjPtr vm = *vmptr;
     qemuDomainObjPrivatePtr priv = vm->privateData;
@@ -11280,8 +11281,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
         if (qemuDomainSnapshotCreateInactive(driver, vm, snap) < 0)
             goto cleanup;
     } else {
-        if (qemuDomainSnapshotCreateActive(domain->conn, driver,
-                                           &vm, snap, flags) < 0)
+        if (qemuDomainSnapshotCreateActiveInternal(domain->conn, driver,
+                                                   &vm, snap, flags) < 0)
             goto cleanup;
     }

-- 
1.7.12




More information about the libvir-list mailing list