[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] qemu: Add option to treat missing USB devices as success



On Wed, Oct 10, 2012 at 16:35:05 +0100, Daniel P. Berrange wrote:
> On Tue, Oct 09, 2012 at 02:13:24PM +0200, Jiri Denemark wrote:
> > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> > index fa5d1f4..3cb1193 100644
> > --- a/src/conf/domain_conf.h
> > +++ b/src/conf/domain_conf.h
> > @@ -386,6 +386,7 @@ struct _virDomainHostdevDef {
> >      int mode; /* enum virDomainHostdevMode */
> >      int startupPolicy; /* enum virDomainStartupPolicy */
> >      unsigned int managed : 1;
> > +    unsigned int missing : 1;
> >      union {
> >          virDomainHostdevSubsys subsys;
> >          struct {
> 
> I was wondering if we should actually expose this in the
> XML, as a read-only attribute, only shown when requesting
> the live XML. Otherwise there's no way for an application
> to determine whether the USB device they requested was
> actually given to the guest, without looking inside the
> guest.

Yeah, this sounds like a useful thing. Could that be a follow up patch to
avoid holding up the whole series just for this? :-)

> ACK to the other parts of the patch

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]