[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Mark missing optional USB devices in domain XML



On 10/11/2012 02:56 PM, Jiri Denemark wrote:
> When startupPolicy set for a USB devices allows such device to be
> missing, there was no way this could be detected from domain XML. With
> this patch, libvirt emits a new missing='yes' attribute for such devices
> when active domain XML is generated.
> ---
>  docs/schemas/domaincommon.rng | 8 ++++++++
>  src/conf/domain_conf.c        | 5 +++++
>  2 files changed, 13 insertions(+)

ACK.

> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index b142716..70bc0e2 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1654,6 +1654,14 @@
>            </optional>
>            <interleave>
>              <element name="source">
> +              <optional>
> +                <attribute name="missing">
> +                  <choice>
> +                    <value>yes</value>
> +                    <value>no</value>

It's a bit odd to see a choice for missing='no', given that we never
output it, and that we ignore it during input, but it doesn't hurt.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]