[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: remove reference to migration in blockcopy



On 10/11/2012 09:14 AM, Ján Tomko wrote:
> ---
>  tools/virsh-domain.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 01550c7..1a9097f 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -1468,13 +1468,13 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd)
>          }
>          if (vshCommandOptInt(cmd, "timeout", &timeout) > 0) {
>              if (timeout < 1) {
> -                vshError(ctl, "%s", _("migrate: Invalid timeout"));
> +                vshError(ctl, "%s", _("invalid timeout"));
>                  return false;
>              }
>  
>              /* Ensure that we can multiply by 1000 without overflowing. */
>              if (timeout > INT_MAX / 1000) {
> -                vshError(ctl, "%s", _("migrate: Timeout is too big"));
> +                vshError(ctl, "%s", _("timeout is too big"));
>                  return false;

Copy-and-paste - evidence that our code could be factored better for
more reuse.  Oh well.

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]