[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Autogenerate AUTHORS



On Sun, Oct 14, 2012 at 1:00 PM, Cole Robinson <crobinso redhat com> wrote:
> On 10/13/2012 05:04 PM, Eric Blake wrote:
>> On 10/13/2012 09:03 AM, Cole Robinson wrote:
>>> On 10/13/2012 11:01 AM, Cole Robinson wrote:
>>>> We add a helper python script build-aux/make-authors.py The .mailmap
>>>> is expanded to give output as close to the original AUTHORS file as
>>>> possible. Drop the syntax-check that validated AUTHORS is up to date.
>>>>
>>>> AUTHORS.in tracks the maintainers, as well as some folks who were
>>>> previously in AUTHORS but don't have a git commit with proper
>>>> attribution.
>>>
>>> Here's the AUTHORS diff it generates. I tried to make sure no one was dropped,
>>> but it could use another look
>>
>> I ran sort on this diff, in en_US.UTF-8, and noticed that:
>>
>> 'Aron Griffis' was added, but with the same email as 'Amy Griffis'
>> (missing a .mailmap entry for preferred name).
>>
>> 'redshift' was added, but with the same email as 'Marco Bozzolan'
>> (another missing .mailmap entry)
>>
>> A couple of names were spelled differently: you fixed Darryl L. Pierce,
>> and changed to Gerd v. Egidy.
>>
>> The duplicate entry 'Serge Hallyn' was consolidated by the 'Serge E.
>> Hallyn' entry.
>>
>
> For the last three, I standardized on the name that was already in AUTHORS.
> I'll fix the first 2.
>
> But as to Rich's comment, anyone object to sorting AUTHORS alphabetically?
> Will simplify this process at least, and if anyone cares about who committed
> when they can check git log.
>
> - Cole

Seems reasonable. The who is more important than the when anyway.

-- 
Doug Goldstein


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]