[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH V1] qemu-attach: Calculate index value if not already specified



virsh qemu-attach fails if user has not specified values
for index/unit/bus for a drive in qemu commandline. Set default
values instead of returning error.

Signed-off-by: Supriya Kannery <supriyak linux vnet ibm com>
---

 src/qemu/qemu_command.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 09f412e..8ba67a1 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7130,16 +7130,6 @@ qemuParseCommandLineDisk(virCapsPtr caps,
         def->bus == VIR_DOMAIN_DISK_BUS_VIRTIO)
         idx = nvirtiodisk;
 
-    if (idx == -1 &&
-        unitid == -1 &&
-        busid == -1) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("missing index/unit/bus parameter in drive '%s'"), val);
-        virDomainDiskDefFree(def);
-        def = NULL;
-        goto cleanup;
-    }
-
     if (idx == -1) {
         if (unitid == -1)
             unitid = 0;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]