[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 15/16] blockjob: wire up online qemu block-commit

On 10/13/2012 04:00 PM, Eric Blake wrote:
> This is the bare minimum to kick off a block commit.  In particular,
> flags support is missing (shallow requires us to crawl the backing
> chain to determine the file name to pass to the qemu monitor command;
> delete requires us to track what needs to be deleted at the time
> the completion event fires).  Also, we are relying on qemu to do
> error checking (such as validating 'top' and 'base' as being members
> of the backing chain), including the fact that the current qemu code
> does not support committing the active layer (although it is still
> planned to add that before qemu 1.3).  Since the active layer won't
> change, we have it easy and do not have to alter the domain XML.
> Additionally, this will fail if SELinux is enforcing, because we fail
> to grant qemu proper read/write access to the files it will modify.
> * src/qemu/qemu_driver.c (qemuDomainBlockCommit): New function.
> (qemuDriver): Register it.
> ---

> @@ -13882,6 +13956,7 @@ static virDriver qemuDriver = {
>      .domainBlockJobSetSpeed = qemuDomainBlockJobSetSpeed, /* 0.9.4 */
>      .domainBlockPull = qemuDomainBlockPull, /* 0.9.4 */
>      .domainBlockRebase = qemuDomainBlockRebase, /* 0.9.10 */
> +    .domainBlockCommit = qemuDomainBlockCommit, /* 0.10.3 */

Given this message[1], I'm fixing this to state 1.0.0.

[1] https://www.redhat.com/archives/libvir-list/2012-October/msg00403.html

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]