[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Fix crash with cleanup



On 10/16/2012 11:48 AM, Michal Privoznik wrote:
> On 16.10.2012 11:19, Martin Kletzander wrote:
>> There was a crash possible when both <boot dev... and <boot
>> order... were specified due to virDomainDefParseBootXML() erroring out
>> before setting *tmp (which was free'd in cleanup).  As a fix, I
>> created this cleanup that uses one pointer for all the temporary
>> stored XPath strings and values, plus this pointer is correctly
>> initialized to NULL.
>> ---
>>  src/conf/domain_conf.c | 21 ++++++++++-----------
>>  1 file changed, 10 insertions(+), 11 deletions(-)
>>
> 
> ACK
> 
> Michal
> 

Thanks, pushed.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]