[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 10/16] storage: remember relative names in backing chain

On 10/16/2012 09:09 AM, Laine Stump wrote:
> On 10/13/2012 06:00 PM, Eric Blake wrote:
>> In order to search for a backing file name as literally present
>> in a chain, we need to remember if the chain had relative names.
>> Also, searching for absolute names is easier if we only have
>> to canonicalize once, rather than on every iteration.
>> * src/util/storage_file.h (_virStorageFileMetadata): Add field.
>> * src/util/storage_file.c (virStorageFileGetMetadataFromBuf):
>> (virStorageFileFreeMetadata): Manage it
>> (absolutePathFromBaseFile): Store absolute names in canonical form.
>> ---
>>  src/util/storage_file.c | 28 ++++++++++++++++++++--------
>>  src/util/storage_file.h |  3 ++-
>>  2 files changed, 22 insertions(+), 9 deletions(-)
>> diff --git a/src/util/storage_file.c b/src/util/storage_file.c
> So I just noticed that this file is in util rather than store. I guess
> because its functions are called both by the storage driver and directly
> from qemu, right?

Correct - and it was that way before I started adding to it.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]