[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 11/16] storage: make it easier to find file within chain



On 10/13/2012 04:00 PM, Eric Blake wrote:
> In order to temporarily label files read/write during a commit
> operation, we need to crawl the backing chain and find the absolute
> file name that needs labeling in the first place, as well as the
> name of the file that owns the backing file.
> 

> +        } else if (owner->backingStoreIsFile) {
> +            char *abs = absolutePathFromBaseFile(*parent, name);
> +            if (abs && STREQ(abs, owner->backingStore)) {
> +                VIR_FREE(abs);
> +                break;
> +            }
> +            VIR_FREE(abs);

I'll have to rename this variable to avoid a -Wshadow warning from older
glibc, such as on RHEL 6.3 (the reduced namespace pollution in newer
glibc on F17 is spoiling me).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]