[libvirt] [PATCHv2 11/16] storage: make it easier to find file within chain

Eric Blake eblake at redhat.com
Tue Oct 16 15:56:32 UTC 2012


On 10/13/2012 04:00 PM, Eric Blake wrote:
> In order to temporarily label files read/write during a commit
> operation, we need to crawl the backing chain and find the absolute
> file name that needs labeling in the first place, as well as the
> name of the file that owns the backing file.
> 

> +        } else if (owner->backingStoreIsFile) {
> +            char *abs = absolutePathFromBaseFile(*parent, name);
> +            if (abs && STREQ(abs, owner->backingStore)) {
> +                VIR_FREE(abs);
> +                break;
> +            }
> +            VIR_FREE(abs);

I'll have to rename this variable to avoid a -Wshadow warning from older
glibc, such as on RHEL 6.3 (the reduced namespace pollution in newer
glibc on F17 is spoiling me).

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121016/43bbf476/attachment-0001.sig>


More information about the libvir-list mailing list