[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set



On 10/16/2012 12:08 PM, Corey Bryant wrote:
> qmp_add_fd() gets an fd that was received over a socket with
> SCM_RIGHTS and adds it to an fd set.  This patch adds support
> that will enable adding an fd that was inherited on the
> command line to an fd set.
> 
> Note: All of the code added to monitor_fdset_add_fd(), with the
> exception of the error path for non-valid fdset-id, is code motion
> from qmp_add_fd().
> 
> Signed-off-by: Corey Bryant <coreyb linux vnet ibm com>
> ---
> v2:
>   -Removed Error** parameter from monitor_fdset_add_fd()
> 
> v3:
>   -Added Error** parameter back to monitor_fdset_add_fd()
>   -Move 'if (!mon_fdset_cur)' change to patch 1 (kwolf redhat com)
>   -Move code that prevents removal of fd from fd set during init
>    to it's own patch (eblake redhat com, kwolf redhat com)
>   -Mention code motion in commit message (kwolf redhat com)

Reviewed-by: Eric Blake <eblake redhat com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]