[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling



On 10/17/2012 11:57 AM, Eric Blake wrote:
On 10/16/2012 09:32 PM, Guannan Ren wrote:

In the subject: s/relablling/relabeling/

It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT
rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE
(commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug)
---
  src/qemu/qemu_command.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
Tested, and fixed the breakage I saw earlier today when running with
SELinux enabled.

ACK.

However, I might add a word of caution in the commit message alerting
anyone trying to do a backport of this patch to be extremely cautious of
where the patch gets applied, as the context of the two hunks is
identical other than indentation.


   Okay, I will add the caution when it is pushed.
   Thanks for the review in so late night.

   Guannan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]