[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Remove spurious whitespace between function name & open brackets



On 10/17/2012 11:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The libvirt coding standard is to use 'function(...args...)'
> instead of 'function (...args...)'. A non-trivial number of
> places did not follow this rule and are fixed in this patch.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
[...]
> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
> index 09f2a92..dc8d1bd 100644
> --- a/src/qemu/qemu_monitor_text.c
> +++ b/src/qemu/qemu_monitor_text.c
> @@ -609,10 +609,10 @@ static int parseMemoryStat(char **text, unsigned int tag,
>      char *dummy;
>      unsigned long long value;
>  
> -    if (STRPREFIX (*text, search)) {
> +    if (STRPREFIX(*text, search)) {
>          *text += strlen(search);
>          if (virStrToLong_ull (*text, &dummy, 10, &value)) {

missed line, space still here  ^

> -            VIR_DEBUG ("error reading %s: %s", search, *text);
> +            VIR_DEBUG("error reading %s: %s", search, *text);
>              return 0;
>          }
>  
[...]
> diff --git a/tests/viratomictest.c b/tests/viratomictest.c
> index d813dbc..88f387b 100644
> --- a/tests/viratomictest.c
> +++ b/tests/viratomictest.c
> @@ -36,7 +36,7 @@ testTypes(const void *data ATTRIBUTE_UNUSED)
>      bool res;
>  
>  #define virAssertCmpInt(a, op, b) \
> -    if (!((a) op (b))) \
> +    if (!(a op b)) \

I believe these should be kept where they are, since there can be
expression used as a argument to this macro.

>          return -1;
>      virAtomicIntSet(&u, 5);
>      u2 = virAtomicIntGet(&u);

Other than those two things, the patch is ok, I'd ACK it, but please
postpone the push until there are at least less people waiting for
back-portable patches.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]