[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Clear async job when p2p migration fails early



On Wed, Oct 17, 2012 at 14:34:25 +0200, Peter Krempa wrote:
> On 10/17/12 14:29, Jiri Denemark wrote:
> > When p2p migration fails early because qemuMigrationIsAllowed or
> > qemuMigrationIsSafe say migration should be cancelled, we fail to clear
> > the migration-out async job. As a result of that, further APIs called
> > for the same domain may fail with Timed out during operation: cannot
> > acquire state change lock.
> >
> > Reported by Guido Winkelmann.
> > ---
> >   src/qemu/qemu_migration.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Or you might move the checks before acquiring the job.

That wouldn't work because the domain is unlocked when we wait for a job and
thus it's definition can change.

> ACK.

Pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]