[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] conf: Add support for HyperV Enlightenment features



On 10/18/12 01:38, Eric Blake wrote:
> On 10/17/2012 07:54 AM, Peter Krempa wrote:
>> Hypervisors are starting to support HyperV englightenment features that
>> improve behavior of guests running Microsoft Windows operating systems.
> 
> s/englightenment/enlightenment/
> 
>>
>> This patch adds support for the "relaxed" feature that improves timer
>> behavior and also establishes a framework to add these features in
>> future.
>> ---
>>   docs/formatdomain.html.in     | 21 ++++++++++++
>>   docs/schemas/domaincommon.rng | 28 +++++++++++++++-
>>   src/conf/domain_conf.c        | 74 +++++++++++++++++++++++++++++++++++++++++--
>>   src/conf/domain_conf.h        | 10 ++++++
>>   src/libvirt_private.syms      |  2 ++
>>   5 files changed, 132 insertions(+), 3 deletions(-)
>>
> 
>> +        for (i = 0; i < n; i++) {
>> +            feature = virDomainHypervTypeFromString((const char *)nodes[i]->name);
> 
> Is this cast really necessary?

Unfortunately, it is:
conf/domain_conf.c: In function 'virDomainDefParseXML':
conf/domain_conf.c:9089:13: error: pointer targets in passing argument 1 of 'virDomainHypervTypeFromString' differ in signedness [-Wpointer-sign]



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]