[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] conf: Make tri-state feature options more universal



On 10/18/12 01:32, Eric Blake wrote:
On 10/17/2012 07:54 AM, Peter Krempa wrote:
The apic-eoi feature enum and implementation can be made more universal
to allow re-use of the enum for other features.
---
  src/conf/domain_conf.c   |  6 +++---
  src/conf/domain_conf.h   | 14 +++++++-------
  src/libvirt_private.syms |  4 ++--
  src/qemu/qemu_command.c  |  6 +++---
  4 files changed, 15 insertions(+), 15 deletions(-)

ACK.  Looking at domain_conf.c, I also see virDomainIoEventFd,
virDomainVirtioEventIdx, virDomainDiskCopyOnRead, virDomainMemDump,
virDomainGraphicsSpicePlaybackCompression, and virDomainPciRombarMode
that also might fit this pattern; would you like to do a followup patch
for those as well, if it makes sense for any of them?


I will have a look what we can do with those.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]