[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] Autogenerate AUTHORS



On 10/18/2012 05:20 PM, Cole Robinson wrote:
> AUTHORS.in tracks the maintainers, as well as some folks who were
> previously in AUTHORS but don't have a git commit with proper
> attribution.
> 
> Generated output is sorted alphabetically and lacks pretty spacing, so
> tweak AUTHORS.in to follow the same format.
> 
> Additionally, drop the syntax-check rule that previously validated
> AUTHORS against git log.
> ---
> 
> I couldn't get the latter chunk of sed magic working... and since nothing
> really makes me reach my frustration limit faster than Makefiles and
> shell trickery, I just stuck with the basic changes.

Fair enough.  I guess if I want it any fancier, I'll actually have to
test my stuff :)

ACK


> +.PHONY: gen-AUTHORS
> +gen-AUTHORS:
> +	if test -d .git; then \
> +	    out="$$(git log --pretty=format:'%aN <%aE>' | sort -u)" && \

I still think `` is safer than $$() in Makefile.am, but not the end of
the world here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]