[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] Autogenerate AUTHORS



On 10/18/2012 09:33 PM, Eric Blake wrote:
> On 10/18/2012 05:20 PM, Cole Robinson wrote:
>> AUTHORS.in tracks the maintainers, as well as some folks who were
>> previously in AUTHORS but don't have a git commit with proper
>> attribution.
>>
>> Generated output is sorted alphabetically and lacks pretty spacing, so
>> tweak AUTHORS.in to follow the same format.
>>
>> Additionally, drop the syntax-check rule that previously validated
>> AUTHORS against git log.
>> ---
>>
>> I couldn't get the latter chunk of sed magic working... and since nothing
>> really makes me reach my frustration limit faster than Makefiles and
>> shell trickery, I just stuck with the basic changes.
> 
> Fair enough.  I guess if I want it any fancier, I'll actually have to
> test my stuff :)
> 
> ACK

Squash this in, so that people doing incremental upgrades aren't bitten
by a nasty-gram from automake about AUTHORS not existing:

diff --git i/cfg.mk w/cfg.mk
index eed7fd8..d3c96ba 100644
--- i/cfg.mk
+++ w/cfg.mk
@@ -699,6 +699,7 @@ ifeq (0,$(MAKELEVEL))
   _clean_requested = $(filter %clean,$(MAKECMDGOALS))
   ifeq (1,$(_update_required)$(_clean_requested))
     $(info INFO: gnulib update required; running ./autogen.sh first)
+    $(shell touch $(srcdir)/AUTHORS $(srcdir)/ChangeLog)
 maint.mk Makefile: _autogen
   endif
 endif

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]