[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-tck PATCH] Debian calls mkisofs genisoimage



On Sat, Oct 20, 2012 at 10:37:50AM -0600, Eric Blake wrote:
> On 10/20/2012 02:26 AM, Guido Günther wrote:
> > so check for that too when generating the iso.
> > ---
> >  lib/Sys/Virt/TCK/NetworkHelpers.pm |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm b/lib/Sys/Virt/TCK/NetworkHelpers.pm
> > index f7f6d70..5e1bac1 100644
> > --- a/lib/Sys/Virt/TCK/NetworkHelpers.pm
> > +++ b/lib/Sys/Virt/TCK/NetworkHelpers.pm
> > @@ -32,8 +32,10 @@ sub build_cdrom_ks_image {
> >      unless (-e $isoimage) {
> >  	my $isofiledir = $tck->bucket_dir($bucket1);
> >  	my $ksfile = $tck->get_scratch_resource($ks, $bucket1, "ks.cfg");
> > +	my @progs = `which mkisofs genisoimage`;
> > +	chomp(@progs);
> >  
> > -	`mkisofs -o "$isoimage" $isofiledir`;
> > +	`$progs[0] -o "$isoimage" $isofiledir`;
> 
> ACK.  Hopefully 'which' is portable enough in practice.
Pushed. Thanks,
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]