[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix the unused parameter which causes the build failure



On 10/22/2012 01:58 AM, Osier Yang wrote:
> ---
> Pushed under build-breaker rule.
> 
> ---
>  src/qemu/qemu_process.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index eef1ddb..969e3ce 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -1999,7 +1999,7 @@ qemuProcessSetLinkStates(virDomainObjPtr vm)
>  
>  /* Set CPU affinities for vcpus if vcpupin xml provided. */
>  static int
> -qemuProcessSetVcpuAffinites(virConnectPtr conn,
> +qemuProcessSetVcpuAffinites(virConnectPtr conn ATTRIBUTE_UNUSED,
>                              virDomainObjPtr vm)

Question - now that we don't need the 'conn' pointer, is it worth a
bigger cleanup that removes the parameter and adjusts all callers?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]