[libvirt] [PATCH] qemu: Fix the unused parameter which causes the build failure

Osier Yang jyang at redhat.com
Mon Oct 22 15:58:39 UTC 2012


On 2012年10月22日 23:48, Eric Blake wrote:
> On 10/22/2012 01:58 AM, Osier Yang wrote:
>> ---
>> Pushed under build-breaker rule.
>>
>> ---
>>   src/qemu/qemu_process.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>> index eef1ddb..969e3ce 100644
>> --- a/src/qemu/qemu_process.c
>> +++ b/src/qemu/qemu_process.c
>> @@ -1999,7 +1999,7 @@ qemuProcessSetLinkStates(virDomainObjPtr vm)
>>
>>   /* Set CPU affinities for vcpus if vcpupin xml provided. */
>>   static int
>> -qemuProcessSetVcpuAffinites(virConnectPtr conn,
>> +qemuProcessSetVcpuAffinites(virConnectPtr conn ATTRIBUTE_UNUSED,
>>                               virDomainObjPtr vm)
>
> Question - now that we don't need the 'conn' pointer, is it worth a
> bigger cleanup that removes the parameter and adjusts all callers?

We will need big cleanup to sort the affinity pinning (the two entries,
sched_setaffinity/libnuma/cgroup), I'd like get rid of things like
together.

Regards,
Osier




More information about the libvir-list mailing list