[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: don't shadow global 'wait' declaration

On 10/23/2012 09:48 AM, Cole Robinson wrote:
> On 10/23/2012 07:33 AM, Ján Tomko wrote:
>> Rename the 'wait' parameter to 'loop'.
>> This silences the warning:
>> storage/storage_backend.c:1348:34: error: declaration of 'wait' shadows
>> a global declaration [-Werror=shadow]
>> and fixes the build with -Werror.
>> --
>> Note: loop is pool backwards.
>> ---
>>  src/storage/storage_backend.c |    8 ++++----
>>  src/storage/storage_backend.h |    2 +-
>>  2 files changed, 5 insertions(+), 5 deletions(-)
> ACK, maybe I have werror disabled?

It also depends on what distro you are building on - the version of gcc,
and the level of namespace pollution in glibc headers, both impact
whether you can reproduce these types of failures even if you have
-Werror turned on.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]