[libvirt] [PATCHv2 00/11] util: add VIR_(INSERT|DELETE)_ELEMENTS_N
Laine Stump
laine at laine.org
Tue Oct 23 17:46:46 UTC 2012
This is a repost of
https://www.redhat.com/archives/libvir-list/2012-October/msg01080.html
with PATCH 03/12 squashed into 01/12. There are no other changes.
************************************
PATCH 01/11 defines a couple new macros/functions to simplify
inserting/deleting items in the middle of an array. The remaining
patches switch over various pieces of existing code to use these new
macros rather than directly calling memmove, etc.
There are several other places where these macros could *almost* be
used, except that they use the model of pre-allocating the larger
array, then performing a bunch of operations (that may fail) and then
finally move items around in the array and adjust its count. I'm
wondering if I should add a flags arg to these to allow for specifying
a "Don't realloc" flag - when it was given, the memory allocation
operation would be presumed already done (in the case of insert) or to
be done after return (for delete). Any opinions on that? (such as
maybe "that's too many options!")
More information about the libvir-list
mailing list