[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier



On 10/24/2012 03:20 AM, Daniel P. Berrange wrote:
> On Tue, Oct 23, 2012 at 12:01:02PM -0600, Eric Blake wrote:
>> Commit 12ad7435 added new functions (virNodeGetMemoryParameters,
>> virNodeSetMemoryParameters) into the section of the file reserved
>> for deprecated names.  Fix this by moving things earlier; split
>> into two patches to make git diff easier to read.
>>
>> * include/libvirt/libvirt.h.in: Move virTypedParameter earlier.
>> ---
>>  include/libvirt/libvirt.h.in | 174 ++++++++++++++++++++++---------------------
>>  1 file changed, 88 insertions(+), 86 deletions(-)
> 
> I have to say I would dearly love to split up our header file into
> a number of pieces, since it is really a huge mess as it is. I'd
> like to have
> 
>     libvirt/virerror.h
>     libvirt/virmisc.h
>     libvirt/virconnect.h
>     libvirt/virdomain.h
>     libvirt/virnetwork.h
>     libvirt/virnodedev.h
>     libvirt/virinterface.h
>     libvirt/..etc...

Agreed, and this is not the first time this has come up.  However, the
last time I attempted this, I ran into walls trying to figure out how to
make the documentation generation work across multiple headers, and it
wasn't high enough on my priorities to resolve at that time.  Also, it
sounds invasive enough to save until after 1.0.0 is released.

> 
> In keeping with the way GTK works, applications would *not* include
> the individual header files directly - they'd simply continue to
> use libvirt.h as now, which would in turn #include all the individual
> pieces.
> 
> 
> Daniel
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]