[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] include: declare typed parameter handling earlier



On Wed, Oct 24, 2012 at 03:31:24PM +0100, Daniel P. Berrange wrote:
> On Wed, Oct 24, 2012 at 08:30:02AM -0600, Eric Blake wrote:
> > On 10/24/2012 03:20 AM, Daniel P. Berrange wrote:

> > Agreed, and this is not the first time this has come up.  However, the
> > last time I attempted this, I ran into walls trying to figure out how to
> > make the documentation generation work across multiple headers, and it
> > wasn't high enough on my priorities to resolve at that time.  Also, it
> > sounds invasive enough to save until after 1.0.0 is released.
> 
> Oh right, forgot about the docs generator pain. Of course it can wait
> till after 1.0.0

  "fixing" the generator should not be too hard, libxml2 also uses
split headers and the generator handle it, I guess it should be a
few lines of cut and paste or copy. The libxml2 version parses all
.h found by glob unless listed in self.excludes, and the libvirt
version evolved to restrict to the ones found in the self.includes

  Two options:
   + extend the include to the new set of files possibly by doing
     a glob in the directory containing libvirt.h
   + switch to an exclude mechanism, but it may become painful to
     maintain

 Related code is docs/apibuild.py rebuild() and docBuilder::scan()

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]