[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] daemon: Fix LIBVIRT_DEBUG=1 default output



On 10/25/2012 04:43 PM, Eric Blake wrote:
> On 10/25/2012 02:35 PM, Cole Robinson wrote:
>>> Thinking about it a bit more, should we be checking if stderr, rather
>>> than stdin, is a ttty?  That is, if you run 'libvirtd </dev/null' from a
>>> terminal, don't you still want output to the stderr tty?
>>>
>>
>> But the libvirtd > out 2>&1 is going to stop working which is a lot more
>> useful then anything stdin related.
> 
> Fair enough - I'm happy to leave the isatty() check on stdin alone.
> 

Thanks Eric, pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]