[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: ignore unsaved emacs files

On 10/25/2012 04:38 PM, Laine Stump wrote:
> On 10/25/2012 06:15 PM, Eric Blake wrote:
>> I did a 'git add .', then realized that it ended up trying to
>> add the emacs lock file for a corresponding file that I had not
>> yet saved all my edits; thankfully I noticed it in time.  Since
>> we already exclude other temporary files, this makes the most
>> sense for preventing such a mistake from actually hitting upstream.
>> * .gitignore: Add .#* to the exclude list.
>> ---
>> If you don't like this patch, then I will be updating my local
>> .git/info/exclude file; I could understand someone wanting to
>> reject this patch on the grounds that 'make' does not create
>> any temporary files under this name, but only my choice of
>> editor (and not everyone shares that choice in editor).  So
>> I'll wait for an ack instead of claiming the trivial rule.

> Well, don't we also ignore *~? That's created by an editor too.


> ACK.

Pushed, before anyone else has a chance to argue against us :)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]