[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Introduce a test suite for the JSON monitor



On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Take advantage of the previously added monitor helpers to
> create a test suite for the QEMU JSON monitor impl. As a
> proof of concept, this tests the 'qemuMonitorGetStatus'
> implementation
> ---
>  .gitignore                  |   1 +
>  tests/Makefile.am           |  11 +++-
>  tests/qemumonitorjsontest.c | 150 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 161 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemumonitorjsontest.c

Every so often (and again today), I get a hung testsuite on
qemumonitorjsontest; on IRC, I mentioned this, and you determined it was
a race where the child thread goes away before the parent enters poll(),
so there is no longer anything to wake up the parent.  You said
something about marking the monitor as closed when you detect EOF, but
I'm not sure what you meant.  Is this something we can get fixed before
1.0.0 is released?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]