Re: [libvirt] [PATCH 01/20] snapshot: new XML for external system checkpoint

[Osier Yang <jyang redhat com>]

On 2012年10月26日 06:42, Eric Blake wrote:
> On 10/23/2012 09:41 PM, Osier Yang wrote:
> > On 2012年10月23日 23:12, Peter Krempa wrote:
> > > From: Eric Blake<eblake redhat com>
> > >
> > > Each<domainsnapshot>   can now contain an optional<memory>
> > > element that describes how the VM state was handled, similar
> > > to disk snapshots.  The new element will always appear in
> > > output; for back-compat, an input that lacks the element will
> > > assume 'no' or 'internal' according to the domain state.
>
> > > So for 0.10.2, I plan to implement this table of combinations,
>
> 1.0.0, now (I'm assuming that this part of the series is worth pushing
> for 1.0.0, even though Peter's series missed the rc1 freeze date)...
>
> Does anyone else have arguments on whether the rest of this series
> should be in or out of the next release?

I think it's safe to push.

> > > +<dt><code>memory</code></dt>
> > > +<dd>On input, this is an optional request for how to handle VM
> > > +        state.  For an offline domain or a disk-only snapshot,
> > > +        attribute<code>snapshot</code>   must be<code>no</code>, since
> > > +        there is no VM state saved; otherwise, the attribute can
> > > +        be<code>internal</code>   if the VM state is piggy-backed with
> > > +        other internal disk state, or<code>external</code>   along with
> > > +        a second attribute<code>file</code>   giving the absolute path
> > > +        of the file holding the VM state.<span class="since">Since
> > > +        0.10.2</span>
>
> and another instance.