[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv9 1/9] blockjob: add qemu capabilities related to block jobs

On 10/26/2012 06:22 AM, Jiri Denemark wrote:
>> I suppose it's not too hard to split this into two patches - one for
>> upstream that uses only drive-mirror (and provides but not populates the
>> feature "drive-reopen",), and one for backporting to RHEL but omitting
>> from upstream that checks the __com.redhat_* commands.  We'll see if any
>> one else has a strong opinion one way or the other

> I think we should keep the mess caused by __com.redhat_* commands and events
> downstream only. We never added such support upstream and we should not start
> doing that. It just make the code more complicated and ugly. Especially when
> the downstream command and the upstream one differ in arguments, name or even
> semantics. I know, we added support for recognizing downstream QEMU as QMP
> capable but that's not the same playground.

Agreed.  I will split the patch into upstream (clean) vs. RHEL-only (for
downstream only).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]