[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv9 9/9] blockjob: relabel entire existing chain



On 10/26/2012 07:43 AM, Peter Krempa wrote:
> On 10/23/12 04:10, Eric Blake wrote:
>> When using block copy to pivot over to a new chain, the backing files
>> for the new chain might still need labeling (particularly if the user
>> passes --reuse-ext with a relative backing file name).  Relabeling a
>> file that is already labeled won't hurt, so this just labels the entire
>> chain at the point of the pivot.  Doing the relabel of the chain uses
>> the fact that we already safely probed the file type of an external
>> file at the start of the block copy.
>>
>> * src/qemu/qemu_driver.c (qemuDomainBlockPivot): Relabel chain before
>> asking qemu to pivot.
>> ---
>>
>> v9: properly restore state when exiting on error
>>
>>   src/qemu/qemu_driver.c | 60
>> +++++++++++++++++++++++++++++++++++++++++++-------
>>   1 file changed, 52 insertions(+), 8 deletions(-)
>>
> 
> ACK.

Thanks again for the review.  I'm now pushing this series; I checked
with DV off-list and he agreed that this series has had enough testing
thanks to RHEL 6.3, and has been posted to the list long enough (in some
form or another for several months now!) that it is worth including
prior to rc2 of 1.0.0.  A note for anyone testing these patches: you'll
need the git://repo.or.cz/qemu/kevin.git:for-anthony branch of qemu,
until Anthony actually honor's Kevin's PULL request.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]