[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] gitignore: ignore more files



On 29.10.2012 10:00, Martin Kletzander wrote:
> On 10/29/2012 07:07 AM, liguang wrote:
>> ignore *.patch, cscope.po.out, cscope.in.out
>>
>> Signed-off-by: liguang <lig fnst cn fujitsu com>
>> ---
>>  .gitignore |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 1cd2d45..d2d6657 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -16,6 +16,7 @@
>>  *.pyc
>>  *.rej
>>  *.s
>> +*.patch
> 
> It shouldn't spoil the repo even if we have *.patch files in already (in
> docs/api_extension/), but doesn't feel clean since there are such files.
>  Anyone feels bad about changing this to '/*.patch' or adding
> '!/docs/api_extension/*.patch' to this?

This is okay since adding *.patch to git repo doesn't feel okay (or
showing it in git status output). Moreover, if somebody wants to add
*.patch he would need explicit 'git add' which will make him think
twice. ACK from me.

> 
>>  *~
>>  .deps
>>  .gdb_history
>> @@ -185,6 +186,8 @@ TAGS
>>  coverage
>>  cscope.files
>>  cscope.out
>> +cscope.in.out
>> +cscope.po.out
>>  results.log
>>  stamp-h
>>  stamp-h.in
>>
> 
> This one is ok.  BTW: Why don't we have 'tags' in .gitignore as well
> (created by ctags target)?
> 
> Martin

Yeah, we should add 'tags' as well.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]