[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] qemu: Fix <address/> is ignored for USB disks



On 30.10.2012 08:28, Vladislav Bogdanov wrote:
> 29.10.2012 17:31, Daniel P. Berrange wrote:
>> On Fri, Oct 26, 2012 at 09:08:41AM +0000, Vladislav Bogdanov wrote:
>>> This is a follow-up to https://bugzilla.redhat.com/show_bug.cgi?id=861309
>>>
>>> If one has USB disks configured for domain with explicit <address/>, libvirtd
>>> ignores that node when building qemu command line. So, disk is connected to
>>> the first free USB port implicitly by qemu.
>>> That breaks other USB devices which have explicit <address/> - ports they
>>> should be connected to may be already occupied by disks.
>>>
>>> With first patch applied, if one has USB disk connected to the USB hub, qemu
>>> fails to start, because it does not know anything about hubs yet (when parsing disks).
>>> That's why second patch is needed.
>>>
>>> Vladislav Bogdanov (2):
>>>   qemu: Do not ignore address for USB disks
>>>   qemu: pass -usb and usb hubs earlier, so USB disks with static
>>>     address are handled properly
>>
>> ACK to both
> 
> Could they be committed before 1.1.0?
> I do not have rights.
> 
> Vladislav

Pushed now.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]