[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: do a better job of matching up pids with their binaries



On 10/30/2012 09:13 AM, Kyle Mestery (kmestery) wrote:
> ACK. 

Thanks. I noticed during my final check that it was still failing make
syntax-check due to the syntax-check rule that prohibits calling
readlink not being specific enough (it prohibited calling any function
that ended with "readlink"), so I squashed in the following change
before pushing:


diff --git a/cfg.mk b/cfg.mk
index d3c96ba..50e6a50 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -386,7 +386,7 @@ sc_prohibit_sprintf:
          $(_sc_search_regexp)
 
 sc_prohibit_readlink:
-       @prohibit='readlink *\('                                        \
+       @prohibit='\<readlink *\('                                      \
        halt='use virFileResolveLink, not readlink'                     \
          $(_sc_search_regexp)
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]